Hi, Marcel
Any other concern on this patch?
Thanks
Best wishes
Yunhan
On Mon, Sep 18, 2017 at 9:47 PM, Yunhan Wang <yunhanw@xxxxxxxxxx> wrote:
> Hi, Marcel
>
> I just run make distcheck, it is working with this change upon latest master.
>
> Could you help to apply it?
>
> The below are detailed step.
> 1. ./configure --prefix=/usr --mandir=/usr/share/man --sysconfdir=/etc
> --localstatedir=/var --enable-experimental
> --with-systemdsystemunitdir=/lib/systemd/system
> --with-systemduserunitdir=/usr/lib/systemd --enable-deprecated
> --enable-tools --enable-testing --enable-experimental
> 2. make distcheck
>
> Thanks
> Best wishes
> Yunhan
>
> On Mon, Aug 28, 2017 at 10:08 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
>> Hi Yunhan,
>>
>>> When building from out of tree, and the top build dir was specified as
>>> an absolute path, the linked headers in ${builddir}/lib/bluetooth were
>>> broken. This patch fixes it by relying on make's abspath macro as
>>> opposed to the path concatenation.
>>> ---
>>> Makefile.am | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Makefile.am b/Makefile.am
>>> index eaed632e8..ad638cbb2 100644
>>> --- a/Makefile.am
>>> +++ b/Makefile.am
>>> @@ -499,7 +499,7 @@ $(lib_libbluetooth_la_OBJECTS): $(local_headers)
>>>
>>> lib/bluetooth/%.h: lib/%.h
>>> $(AM_V_at)$(MKDIR_P) lib/bluetooth
>>> - $(AM_V_GEN)$(LN_S) -f "$(abs_top_builddir)"/$< $@
>>> + $(AM_V_GEN)$(LN_S) -f $(abspath $<) $@
>>
>> does “fakeroot make distcheck” still works when doing this change?
>>
>> Regards
>>
>> Marcel
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
