Re: [PATCH BlueZ] client: Fix default_ctrl change when new adapter is found

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, ERAMOTO

On Sun, Sep 3, 2017 at 5:48 PM, ERAMOTO Masaya
<eramoto.masaya@xxxxxxxxxxxxxx> wrote:
> Hi Yunhan,
>
> On 09/02/2017 12:54 PM, Yunhan Wang wrote:
>> Hi, ERAMOTO
>>
>> On Fri, Sep 1, 2017 at 12:59 AM, ERAMOTO Masaya
>> <eramoto.masaya@xxxxxxxxxxxxxx> wrote:
>>> Hi Yunhan,
>>>
>>> Thanks for your explanation.
>>>
>>> Btw, could you also tell me about the following fix.
>>
>> default_ctrl would be set as NULL in disconnect_handler. Therefore I
>> remove this redundant one.
>>
>
> It seems g_dbus_client_unref() calls disconnect_handler() when g_main_loop_run()
> is exited by quit command etc.. So I think here defautl_ctrl should be set as
> NULL in interactive mode.
>

Yes, just send patch to fix it.

>>
>>> bluetoothclt sometimes do core dump when I detach the adapter of default_ctrl
>>> and run show command.
>>
>> Could you share your reproduce step for this issue? Could it be
>> constantly reproduced?
>
> It is always reproduced with the following steps:
>
>   1. Attach an adapter.
>   2. Run bluetoothctl.
>   3. Detach this adapter.
>   4. Run device command in bluetootctl.
>
With the new fix, when you detach adapter, the default_ctrl become
NULL, you should not see the devices via running devices cmd.
>
> Regards,
> Eramoto
>
>>
>> thanks
>> best wishes
>> yunhan
>>
>>
>

thanks
best wishes
yunhan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux