RE: [PATCH BlueZ 1/3] mesh: Fix for handling unprovisioned device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a good fix and should be accepted.

> -----Original Message-----
> From: linux-bluetooth-owner@xxxxxxxxxxxxxxx [mailto:linux-bluetooth-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Gix, Brian
> Sent: Thursday, August 31, 2017 4:12 PM
> To: Lukasz Rymanowski <lukasz.rymanowski@xxxxxxxxxxx>; linux-
> bluetooth@xxxxxxxxxxxxxxx
> Subject: RE: [PATCH BlueZ 1/3] mesh: Fix for handling unprovisioned device
> 
> An unprovisioned device that does not advertise the ServiceData for an
> Unprovisioned Mesh Device does not comply with the specification.  The
> Service Data is the required method for an unprovisioned device to be
> recognized.
> 
> > -----Original Message-----
> > From: linux-bluetooth-owner@xxxxxxxxxxxxxxx [mailto:linux-bluetooth-
> > owner@xxxxxxxxxxxxxxx] On Behalf Of Lukasz Rymanowski
> > Sent: Thursday, August 31, 2017 3:13 AM
> > To: linux-bluetooth@xxxxxxxxxxxxxxx
> > Cc: Łukasz Rymanowski <lukasz.rymanowski@xxxxxxxxxxx>
> > Subject: [PATCH BlueZ 1/3] mesh: Fix for handling unprovisioned device
> >
> > If there is no ServiceData there is no valid provisioning data for
> > PB-GATT
> > ---
> >  mesh/main.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mesh/main.c b/mesh/main.c index b06f4352a..2289d7d10
> > 100644
> > --- a/mesh/main.c
> > +++ b/mesh/main.c
> > @@ -503,7 +503,7 @@ static bool parse_service_data(GDBusProxy *proxy,
> > const char *target_uuid,
> >  	}
> >
> >  	if (!g_dbus_proxy_get_property(proxy, "ServiceData", &iter))
> > -		return true;
> > +		return false;
> >
> >  	if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_ARRAY)
> >  		return false;
> > --
> > 2.11.0
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo
> info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux