Re: [PATCH v2] gdbus: Fix calling GetAll while GetManagedObject is pending

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Aug 14, 2017 at 8:16 PM, Vinicius Costa Gomes
<vinicius.gomes@xxxxxxxxx> wrote:
> Hi Luiz,
>
> Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> writes:
>
>> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>>
>> If proxies are created while the client is not ready put them into a
>> pending list so only if they are not found in GetManagedObject reply
>> call GetAll.
>> ---
>>  gdbus/client.c | 96 ++++++++++++++++++++++++++++++++++++----------------------
>>  1 file changed, 59 insertions(+), 37 deletions(-)
>>
>
> [...]
>
>> @@ -424,6 +435,7 @@ static GDBusProxy *proxy_new(GDBusClient *client, const char *path,
>>                                                       proxy->interface,
>>                                                       properties_changed,
>>                                                       proxy, NULL);
>> +     proxy->pending = TRUE;
>>
>>       return g_dbus_proxy_ref(proxy);
>>  }
>> @@ -478,15 +490,19 @@ GDBusProxy *g_dbus_proxy_new(GDBusClient *client, const char *path,
>>       if (client == NULL)
>>               return NULL;
>>
>> -     proxy = proxy_lookup(client, path, interface);
>> +     proxy = proxy_lookup(client->proxy_list, path, interface);
>>       if (proxy)
>>               return g_dbus_proxy_ref(proxy);
>>
>> +
>
> Extra empty line here.

Fixed this one, thanks for pointing out.

>>       proxy = proxy_new(client, path, interface);
>>       if (proxy == NULL)
>>               return NULL;
>>
>
> Just that nitpick, looking good.

Applied.

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux