Re: [PATCH] net/bluetooth: make bluetooth socket can be created in net namespace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2017/8/14 17:30, Marcel Holtmann wrote:
Hi Fupan,

By now kernel only supported creating bluetooth socket in init_net
net namespace, which made bluetooth device cannot be accessed in
containers, this patch made bluetooth socket can be created in
net namespaces to fix this issue.

Signed-off-by: Fupan Li <fupan.li@xxxxxxxxxxxxx>
---
net/bluetooth/af_bluetooth.c | 2 +-
net/bluetooth/bnep/sock.c    | 4 ++--
net/bluetooth/cmtp/sock.c    | 4 ++--
net/bluetooth/hci_sock.c     | 4 ++--
net/bluetooth/hidp/sock.c    | 4 ++--
net/bluetooth/l2cap_sock.c   | 4 ++--
net/bluetooth/rfcomm/core.c  | 2 +-
net/bluetooth/rfcomm/sock.c  | 4 ++--
net/bluetooth/sco.c          | 4 ++--
9 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/net/bluetooth/af_bluetooth.c b/net/bluetooth/af_bluetooth.c
index 91e3ba280706..eec5ac17faee 100644
--- a/net/bluetooth/af_bluetooth.c
+++ b/net/bluetooth/af_bluetooth.c
@@ -113,7 +113,7 @@ static int bt_sock_create(struct net *net, struct socket *sock, int proto,
{
	int err;

-	if (net != &init_net)
+	if (!net_eq(net, current->nsproxy->net_ns))
		return -EAFNOSUPPORT;
before I apply such a patch, what is the actual change here. What impact does this have? Are things like Bluetooth mgmt sockets still operating correctly after this? We have no support for move a Bluetooth controller into a container. The Bluetooth hardware is global.
Hi, Marcel

This patch hasn't nothing to do with the Bluetooth hardware, the hardware is still global. But before you apply this patch, you cannot access the bluetooth hardware in a container, since you cannot create a bluetooth socket if you are not in the init_net namespace. After applying this patch, you can access the bluetooth hardware both in the init_net namespace
and containers.


Fupan

Regards

Marcel



--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux