Hi Vinicius, On Mon, Aug 14, 2017 at 11:23 AM, Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> wrote: > Hi Vinicius, > > On Fri, Aug 11, 2017 at 10:56 PM, Vinicius Costa Gomes > <vinicius.gomes@xxxxxxxxx> wrote: >> Hi Luiz, >> >> Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> writes: >> >>> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx> >>> >>> If proxies are created while the client is not ready put them into a >>> pending list so only if they are not found in GetManagedObject reply >>> call GetAll. >> >> I tested this with a hacked gdbus/object.c to get into that >> GetAll/GetManagedObjects condtion, and it works. >> >> I just think that it could be simplified somewhat. What I am thinking is >> that we don't need a "pending" list, each proxy can have a 'pending' >> boolean, and instead we add it to proxy_list as soon as it is allocated. > > Tried that, but that felt a little more complicated than maintaining a > list since we have to iterate the entire proxy_list to find which ones > are pending. > >> I didn't try it, but it feels like it would work. >> >> What do you think? >> >> If you don't think it would work, or that it would end up harder to >> read, this patch looks good to me. > > Will apply it then. Actually, I went back on this and did a v2 with the boolean flag, the thing I said about reiterating is actually cheaper than doing the lookup on on the proxy_list then is not found append the proxy and remove it from the pending_list. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
