Hi Marcel,
On Wed, Jul 19, 2017 at 12:28 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> Hi Luiz,
>
>>>> This reduces the verbosity and give a precise picture of how unique
>>>> each report is.
>>>> ---
>>>> monitor/intel.c | 28 +++---
>>>> monitor/packet.c | 277 ++++++++++++++++++++++++++++++++++++-------------------
>>>> monitor/vendor.h | 2 +-
>>>> 3 files changed, 198 insertions(+), 109 deletions(-)
>>>>
>>>> diff --git a/monitor/intel.c b/monitor/intel.c
>>>> index 1ca9a95..9da188a 100644
>>>> --- a/monitor/intel.c
>>>> +++ b/monitor/intel.c
>>>> @@ -499,11 +499,11 @@ const struct vendor_ocf *intel_vendor_ocf(uint16_t ocf)
>>>> return NULL;
>>>> }
>>>>
>>>> -static void startup_evt(const void *data, uint8_t size)
>>>> +static void startup_evt(uint8_t index, const void *data, uint8_t size)
>>>> {
>>>> }
>>>
>>> NAK. I avoid this and want to keep avoiding it. There are different ways to get the actual index number if you need it. And also FYI, the index is a uint16_t.
>>
>> I haven't figure out any other way to pass down the index number, or
>> do you want some like l2cap_frame so it can carry information such as
>> the index.
>
> using index_current was too complicated ;)
Sure thing, I got the impression we didn't have anything pointing to
the current index since we use to pass down the index in some
callback, anyway will use that.
Btw, speaking about BFP it does look like we could use for index
filtering as well.
--
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
