Re: [PATCH 4/4] bluetooth: Add HCI_QUIRK_INVALID_BDADDR for BCM43430A0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/07/17 19:01, Marcel Holtmann wrote:

>> Is it intended behaviour that you cannot change the address via btmgmt
>> if the device started with a valid bdaddr? obviously this patch is
>> incorrect, but without it, btmgmt public-addr <foo> fails.
>>
>> OTOH, bdaddr does not fail - which seems inconsistent to me. Surely
>> either both should work, or both fail?
> 
> you can change them, but the you need a btmgmt power off first. Changing the address while the controller powered on is not possible. You need to reset the controller to have the changes take affect.

Aha, thats the magic sauce :) Thanks.

>> eg. - there is *no* legitimate reason for userspace to send a firmware
>> load command to the chip via my driver, since its already handled by the
>> kernels firmware mechanism - attempting to do so should fail, IMO
> 
> Yes. These are legacy UART drivers. We try to phase these out.

I could look into the feasibility of filtering the command stream if you
are interested in a patch to that effect?

-Ian
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux