Hi, On Sat, Jul 08, 2017 at 03:29:48PM +0100, Ian Molton wrote: > Simplify _remove() path for hci_nokia.c > > Signed-off-by: Ian Molton <ian@xxxxxxxxxxxxxx> > --- > drivers/bluetooth/hci_nokia.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/bluetooth/hci_nokia.c b/drivers/bluetooth/hci_nokia.c > index 6dbb1f6ff6bd..1a465dd2970e 100644 > --- a/drivers/bluetooth/hci_nokia.c > +++ b/drivers/bluetooth/hci_nokia.c > @@ -770,11 +770,7 @@ static void nokia_bluetooth_serdev_remove(struct serdev_device *serdev) > struct hci_uart *hu = &btdev->hu; > struct hci_dev *hdev = hu->hdev; > > - > - hci_unregister_dev(hdev); > - hci_free_dev(hdev); > - > - cancel_work_sync(&hu->write_work); > + hci_uart_unregister_device(hdev); > > hu->proto->close(hu); > } I think "hu->proto->close(hu)" should also be moved into the helper function. Also I suggest to use hci_uart instead of hci_dev as parameter for hci_uart_unregister_device, which matches the related hci_uart_register_device. -- Sebastian
Attachment:
signature.asc
Description: PGP signature
