Re: PATCH: Nokia HCI driver minor issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/07/17 11:49, Sebastian Reichel wrote:
> Hi,
> 
> On Fri, Jul 07, 2017 at 11:03:28PM +0100, Ian Molton wrote:
>> I've collected a couple of patches together over the last week, they
>> might be of use.
>>
>> I'm not entirely certain the 2nd one is the *correct* fix, as I could
>> only test my (very similar) driver I've based off this one, but it WFM.
>>
>> --Ian
> 
> Please always send using get-send-email(1) mail style.

I always do when sending a patch thats final. This was just for comments.
>> -------------------------------------------------------------------
>> From 3e5182a84717acd5eadd645294a008bcf27201a0 Mon Sep 17 00:00:00 2001
>> From: Ian Molton <ian@xxxxxxxxxxxxxx>
>> Date: Tue, 4 Jul 2017 15:01:46 +0100
>> Subject: [PATCH 1/3] Bluetooth: Nokia HCIUART driver should depend on H4
>>
>> 	The Nokia H4+ driver causes a build error if BT_HCIUART_H4
>> is not configured. Make it depend on this symbol.
>>
>>
>> Signed-off-by: Ian Molton <ian@xxxxxxxxxxxxxx>
> 
> You are on an old branch. Current mainline selects BT_HCIUART_H4.

Wow, thats recent, yeah, mainline has that fixed *since* 4.12. FML :)

> Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxxxx>

I'll update and resend the other two patches - Thanks for the review!

-Ian
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux