Hi Marcel,
On Tue, May 2, 2017 at 9:54 AM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> If the Channel Selection Algorithm #2 feature is supported, then enable
> the new LE Channel Selection Algorithm event.
>
> Signed-off-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>
> ---
> include/net/bluetooth/hci.h | 1 +
> net/bluetooth/hci_core.c | 8 ++++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index 99aa5e5e3100..dd43cfdd443a 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -399,6 +399,7 @@ enum {
> #define HCI_LE_PING 0x10
> #define HCI_LE_DATA_LEN_EXT 0x20
> #define HCI_LE_EXT_SCAN_POLICY 0x80
> +#define HCI_LE_CHAN_SEL_ALG2 0x40
>
> /* Connection modes */
> #define HCI_CM_ACTIVE 0x0000
> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> index 4a0cac774107..e58b9034afff 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -635,6 +635,14 @@ static int hci_init3_req(struct hci_request *req, unsigned long opt)
> * Report
> */
>
> + /* If the controller supports Channel Selection Algorithm #2
> + * feature, enable the corresponding event.
> + */
> + if (hdev->le_features[1] & HCI_LE_CHAN_SEL_ALG2)
> + events[2] |= 0x08; /* LE Channel Selection
> + * Algorithm
> + */
It might look better if you move the comments before the assignment
and it may actually fit in a single line. Btw, shoudn't we have a
define for 0x08?
> /* If the controller supports the LE Set Scan Enable command,
> * enable the corresponding advertising report event.
> */
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
