On 03/31, Von Dentz, Luiz wrote: > Hi Konrad, > > On Fri, Mar 31, 2017 at 2:32 PM, Konrad Zapalowicz > <konrad.zapalowicz@xxxxxxxxxxxxx> wrote: > > On 03/31, Bastien Nocera wrote: > >> On Fri, 2017-03-31 at 13:03 +0200, Konrad Zapalowicz wrote: > >> > From: Konrad Zapałowicz <konrad.zapalowicz@xxxxxxxxxxxxx> > >> > > >> > This commit replaces sizeof(filename) with PATH_MAX to match the > >> > common > >> > scheme which is used in other places. > >> > >> I wonder why g_strdup_printf() isn't used instead. Would allow ignoring > >> PATH_MAX. > > > > I guess it is because it is easier. With g_strdup_printf() one would > > have to take care about freeing memory. This is not a case with having > > filename as an atomatic variable. > > Patch looks fine, but we don't use Signed-off-by in userspace tree Ok, will resend. Thanks, K -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html