On Thu, Mar 30, 2017 at 6:17 AM, Xinming Hu <huxm@xxxxxxxxxxx> wrote: > Hi Guenter, > >> -----Original Message----- >> From: Guenter Roeck [mailto:groeck@xxxxxxxxxx] >> Sent: 2017年3月30日 20:58 >> To: Xinming Hu >> Cc: Linux Bluetooth; Marcel Holtmann; Amitkumar Karwar; Cathy Luo; Guenter >> Roeck >> Subject: [EXT] Re: [PATCH 2/2] Bluetooth: btmrvl: remove unnecessary wakeup >> interrupt number sanity check >> >> External Email >> >> ---------------------------------------------------------------------- >> On Thu, Mar 30, 2017 at 5:52 AM, Xinming Hu <huxm@xxxxxxxxxxx> wrote: >> > Sanity check of interrupt number in interrupt handler is unnecessary >> > and confusion, remove it. >> > >> > Signed-off-by: Xinming Hu <huxm@xxxxxxxxxxx> >> > Signed-off-by: Guenter Roeck <groeck@xxxxxxxxxxxx> >> >> Do you possibly mean "Reported-by:" ? > > The patch is prepared based on your suggestions on https://issuetracker.google.com/issues/35647652 > This means that either "Reported-by:" or "Suggested-by:" would be appropriate, but not "Signed-off-by:". Thanks, Guenter > Thanks > Simon >> >> > Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx> >> > --- >> > drivers/bluetooth/btmrvl_sdio.c | 9 +++------ >> > 1 file changed, 3 insertions(+), 6 deletions(-) >> > >> > diff --git a/drivers/bluetooth/btmrvl_sdio.c >> > b/drivers/bluetooth/btmrvl_sdio.c index 6166888..7a26961 100644 >> > --- a/drivers/bluetooth/btmrvl_sdio.c >> > +++ b/drivers/bluetooth/btmrvl_sdio.c >> > @@ -62,12 +62,9 @@ static irqreturn_t btmrvl_wake_irq_bt(int irq, void >> > *priv) { >> > struct btmrvl_plt_wake_cfg *cfg = priv; >> > >> > - if (cfg->irq_bt >= 0) { >> > - pr_info("%s: wake by bt", __func__); >> > - cfg->wake_by_bt = true; >> > - disable_irq_nosync(irq); >> > - } >> > - >> > + pr_info("%s: wake by bt", __func__); >> > + cfg->wake_by_bt = true; >> > + disable_irq_nosync(irq); >> > return IRQ_HANDLED; >> > } >> > >> > -- >> > 1.8.1.4 >> > -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
