Hello, Le 10/02/2017 à 12:41, Marcel Holtmann a écrit :
Hi Jonas,Do not change from init_speed to oper_speed per default since it may cause failures and timeouts if the uart cannot handle the new speed. orig_speed should probably be set using device tree instead. --- drivers/bluetooth/hci_bcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c index 8f6c23c..7787f82 100644 --- a/drivers/bluetooth/hci_bcm.c +++ b/drivers/bluetooth/hci_bcm.c @@ -809,7 +809,7 @@ static const struct hci_uart_proto bcm_proto = { .name = "Broadcom", .manufacturer = 15, .init_speed = 115200, - .oper_speed = 4000000, + .oper_speed = 0, .open = bcm_open, .close = bcm_close, .flush = bcm_flush,I am generally fine with this, but the DT support for Broadcom UART devices is not yet upstream. And we need to make sure this also works for ACPI based devices. If we can get the max UART speed from ACPI, then I am fine doing it this way.
Afair, the max UART speed is nor provided from ACPI, only the initial speed is provided, at least for the Asus T100TA.
Regards, Frédéric -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
