Re: [PATCH] tools/btattach: Add detach option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Carl,

> Signed-off-by: Carlo Caione <carlo@xxxxxxxxxxxx>

user space does not use signed off by statements.

> ---
> tools/btattach.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/btattach.c b/tools/btattach.c
> index 5adbc8d..f1f115d 100644
> --- a/tools/btattach.c
> +++ b/tools/btattach.c
> @@ -194,6 +194,7 @@ static void usage(void)
> 		"\t-P, --protocol <proto> Specify protocol type\n"
> 		"\t-S, --speed <baudrate> Specify which baudrate to use\n"
> 		"\t-N, --noflowctl        Disable flow control\n"
> +		"\t-D, --detach           Open device and then fork\n"
> 		"\t-h, --help             Show help options\n”);

And is this really a good idea. I think that I had removed all the fork calls from the standard tools. Mainly since we fail to maintain the signals and more important child signals correctly. So we quickly end up with zombies or orphaned processes. My thinking instead was to leave this to systemd to handle.

In addition, we are close to getting serdev bus which means btattach will be something of the past really soon.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux