Hi Brian, On 24 January 2017 at 20:04, Gix, Brian <brian.gix@xxxxxxxxx> wrote: > Done. > > -----Original Message----- > From: linux-bluetooth-owner@xxxxxxxxxxxxxxx [mailto:linux-bluetooth-owner@xxxxxxxxxxxxxxx] On Behalf Of Felipe Ferreri Tonello > Sent: Tuesday, January 24, 2017 10:56 AM > To: Gix, Brian <brian.gix@xxxxxxxxx>; linux-bluetooth@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 2/2] Require GLIB v2.46 > > Hi Brian, > > Please, add the reason why this change is necessary in the commit message. > > On 24/01/17 18:29, Brian Gix wrote: >> --- >> configure.ac | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/configure.ac b/configure.ac index 91b4955..6d8bf9c 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -61,8 +61,8 @@ AC_CHECK_LIB(dl, dlopen, dummy=yes, >> >> AC_CHECK_HEADERS(linux/types.h linux/if_alg.h) >> >> -PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.28, dummy=yes, >> - AC_MSG_ERROR(GLib >= 2.28 is required)) >> +PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.46, dummy=yes, >> + AC_MSG_ERROR(GLib >= 2.46 is required)) >> AC_SUBST(GLIB_CFLAGS) >> AC_SUBST(GLIB_LIBS) I'd rather change test instead of bumping glib dependency just for this... But I'll let others to comment on this too. -- pozdrawiam Szymon K. Janc -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
