On Fri, Jan 13, 2017 at 9:04 AM, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > On Thu, 2017-01-12 at 10:01 -0600, Rob Herring wrote: >> On Sat, Jan 7, 2017 at 8:11 AM, Andy Shevchenko >> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: >> > On Fri, 2017-01-06 at 10:26 -0600, Rob Herring wrote: >> > > Add a serdev controller driver for tty ports. >> > > >> > > The controller is registered with serdev when tty ports are >> > > registered >> > > with the TTY core. As the TTY core is built-in only, this has the >> > > side >> > > effect of making serdev built-in as well. >> > > >> > > >> > > +if SERIAL_DEV_BUS >> > > + >> > > +config SERIAL_DEV_CTRL_TTYPORT >> > > + bool "Serial device TTY port controller" >> > > + depends on TTY >> > > + depends on SERIAL_DEV_BUS=y >> > >> > Do you need one? >> >> Yes, otherwise the bus can be built as a module and this driver can >> still be enabled breaking the build. I could drop supporting building >> the bus as a module because as long as this is the only controller >> driver, it all has to be built-in. > > Would > > if SERIAL_DEV_BUS=y > > work for you? Yes, until we add a driver that doesn't have to be built-in. What about "depends on SERIAL_DEV_BUS != m"? That would be a bit more clear what the reason is. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html