Re: [PATCH 2/3] Bluetooth: Fix local name validation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michal,

> Short name should be shorter than complete name
> and it should be a prefix of complete name.
> 
> Signed-off-by: Michał Narajowski <michal.narajowski@xxxxxxxxxxx>
> ---
> net/bluetooth/mgmt.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
> 
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index 7b2bac4..5709377 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -3099,6 +3099,24 @@ unlock:
> 	hci_dev_unlock(hdev);
> }
> 
> +static bool name_is_valid(u8 *complete_name, u8 *short_name)
> +{
> +	size_t complete_len = strlen(complete_name);
> +	size_t short_len = strlen(short_name);
> +
> +	if (complete_len <= short_len)
> +		return false;
> +
> +	/* Core Specification Supplement, A, 1.2.1:
> +	 * A shortened name shall only contain contiguous characters from
> +	 * the beginning of the full name.
> +	 */
> +	if (strncmp(short_name, complete_name, short_len) != 0)
> +		return false;
> +
> +	return true;
> +}
> +

actually I do not want to enforce that from the kernel side. Lets keep the mgmt interface flexible and let bluetoothd enforce this if needed.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux