Re: [PATCH BlueZ 1/2] core/device: Fix attempting to connect to random address over BR/EDR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,

On Fri, Sep 02, 2016, Luiz Augusto von Dentz wrote:
> BR/EDR don't have the concept of random addresses so the only option is
> to over LE in that case.
> ---
>  src/device.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/device.c b/src/device.c
> index fb766d1..b8556f1 100644
> --- a/src/device.c
> +++ b/src/device.c
> @@ -1748,6 +1748,10 @@ static uint8_t select_conn_bearer(struct btd_device *dev)
>  	else if (!dev->bredr_state.bonded && dev->le_state.bonded)
>  		return dev->bdaddr_type;
>  
> +	/* If the address is private it can only be connected over LE */
> +	if (device_address_is_private(dev))
> +		return dev->bdaddr_type;
> +

This doesn't look right to me. The comment also isn't correct since a
dual mode device may use a resolvable private address for LE, i.e.
device_address_is_private(dev) would return true. IIRC the
dev->bdaddr_type value tells the LE address type when LE is supported.
If LE is not supported then dev->bdaddr_type is BDADDR_BREDR.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux