Re: [PATCH BlueZ] core/device: Fix not connecting services properly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Aug 12, 2016 at 11:26 AM, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>
> Device.Connect shall check if the service discovery is pending or no
> service have been connected yet before switching to LE otherwise these
> services may never be connected.
> ---
>  src/device.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/src/device.c b/src/device.c
> index 6c6be92..c103bb2 100644
> --- a/src/device.c
> +++ b/src/device.c
> @@ -1779,9 +1779,18 @@ static DBusMessage *dev_connect(DBusConnection *conn, DBusMessage *msg,
>         struct btd_device *dev = user_data;
>         uint8_t bdaddr_type;
>
> -       if (dev->bredr_state.connected)
> -               bdaddr_type = dev->bdaddr_type;
> -       else if (dev->le_state.connected && dev->bredr)
> +       if (dev->bredr_state.connected) {
> +               /*
> +                * Check if services have been resolved and there is at list
> +                * one connected before switching to connect LE.
> +                */
> +               if (dev->bredr_state.svc_resolved &&
> +                       find_service_with_state(dev->services,
> +                                               BTD_SERVICE_STATE_CONNECTED))
> +                       bdaddr_type = dev->bdaddr_type;
> +               else
> +                       bdaddr_type = BDADDR_BREDR;
> +       } else if (dev->le_state.connected && dev->bredr)
>                 bdaddr_type = BDADDR_BREDR;
>         else
>                 bdaddr_type = select_conn_bearer(dev);
> --
> 2.7.4

Applied.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux