Hi Ryan, > I wanted to check whats the best way of going about adding > suspend-resume support for bcm bt chip > > Should one have a separate driver > (https://android.googlesource.com/kernel/bcm/+/3d6d35972004824a9111f13926bed2a4a495b668/drivers/misc/bcm-bt-lpm.c) > > or should i use the existing hci_bcm.c driver & add dt support or use > a platform device to pass the gpiod_desc for wakeup/sleep? no separate driver please. As soon as btattach links the UART and we enable the device, everything should be done in background by the driver. The Broadcom LPM driver is just a hack for Android since they still haven't switched to using HCI User Channel for Android (like Intel for example). In general DT and ACPI are the same. They describe the hardware and there are methods to read these descriptions from them and then use them. The only problem with DT was that Broadcom never got the definition acked by the DT maintainer. Otherwise all the functionality should be already in hci_bcm.c right now. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html