Hi Jaya, please do not top-post on this mailing list. It is against its etiquette. > I am sending the first patch to Bluetooth-next. > Regarding the coding guidelines, Attached a new patchset with the coding guidelines, except for removing the kobject changes. The kobject exposing from the driver is not acceptable. That is something that is just a plain hack. It is not a clean solution and can not be accepted upstream. > And regarding this requirement, this came for google chrome to check the > Different SKU's version on the go rather than issuing read version command for the controller. What is the difference? I do not get it. It is specific to Intel anyway. How is this done for Broadcom or Marvell controllers? Someone needs to shed some light into this requirement. Either this is a common way for all controllers to expose a vendor revision string or it is not useful in the broader sense at all. > And so, the design proposed that we expose a kobject file for this from btusb . > And for your understanding, the Intel FW file pushed for the controller will have these 3 components > HW Variant : 0x000000 > FW Variant: 0x0000000000 > Patch number: 0x00 > Which is not the same for all the vendors, this information required to check which controller is > Inserted in our linux pc, so an additional information along VID, PID information which is same different Intel Controllers. > This is required because, Intel SKU's have same VID,PID for different chips i.e for XX B0, XX B1 will have the same VID, PID. I know how our SKUs work, but exposing the raw numbers is still not doing much in the end. You want to decode the numbers into something real. That is what bluemoon actually does. > And the Linux PC or the OEM that we are supporting can have only one Bluetooth controller, so the > Issue that you mention never happens. Please forget about this kind of reasoning right away. That does not work with upstream. This argument alone would be a reason to reject the patch. This Linux kernel runs on multiple systems and if I attach two Intel controllers to my desktop system, I want them to work. Full stop here. You can not break other peoples machines only because this is out of scope for you. This means any design has to take this into account. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
