Hi Ingo, >>> SMP does ECB crypto on stack buffers. This is complicated and >>> fragile, and it will not work if the stack is virtually allocated. >>> >>> Switch to the crypto_cipher interface, which is simpler and safer. >>> >>> Cc: Marcel Holtmann <marcel@xxxxxxxxxxxx> >>> Cc: Gustavo Padovan <gustavo@xxxxxxxxxxx> >>> Cc: Johan Hedberg <johan.hedberg@xxxxxxxxx> >>> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> >>> Cc: linux-bluetooth@xxxxxxxxxxxxxxx >>> Cc: netdev@xxxxxxxxxxxxxxx >>> Acked-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> >>> Acked-and-tested-by: Johan Hedberg <johan.hedberg@xxxxxxxxx> >>> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx> >>> --- >>> net/bluetooth/smp.c | 67 ++++++++++++++++++++++------------------------------- >>> 1 file changed, 28 insertions(+), 39 deletions(-) >> >> patch has been applied to bluetooth-next tree. > > Sadly carrying this separately will delay the virtual kernel stacks feature by a > kernel cycle, because it's a must-have prerequisite. I can take it back out, but then I have the fear the the ECDH change to use KPP for SMP might be the one that has to wait a kernel cycle. Either way is fine with me, but I want to avoid nasty merge conflicts in the Bluetooth SMP code. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
