Re: [RFC 4/4] bluetooth: Do not set IFF_POINTOPOINT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Patrik,

On Mon, Jun 20, 2016 at 10:49 AM, Patrik Flykt
<patrik.flykt@xxxxxxxxxxxxxxx> wrote:
> The IPv6 stack needs to send and receive Neighbor Discovery
> messages. Remove the IFF_POINTOPOINT flag.

I guess we can quote the https://tools.ietf.org/html/rfc7668#section-2.2:


   ' In Bluetooth LE, direct wireless communication only takes place
   between a central and a peripheral.  This means that inherently the
   Bluetooth LE star represents a hub-and-spokes link model.
   Nevertheless, two peripherals may communicate through the central by
   using IP routing functionality per this specification.'

I guess this means the router should act as a hub, there is actually a
dedicated session for Neighbor Discovery:
https://tools.ietf.org/html/rfc7668#section-3.2.3

*We might have to check if we are conforming to things like not
publishing link-local addresses.


> Signed-off-by: Patrik Flykt <patrik.flykt@xxxxxxxxxxxxxxx>
> ---
>  net/bluetooth/6lowpan.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
> index 2dddb2b..1a70312 100644
> --- a/net/bluetooth/6lowpan.c
> +++ b/net/bluetooth/6lowpan.c
> @@ -650,8 +650,7 @@ static void netdev_setup(struct net_device *dev)
>  {
>         dev->hard_header_len    = 0;
>         dev->needed_tailroom    = 0;
> -       dev->flags              = IFF_RUNNING | IFF_POINTOPOINT |
> -                                 IFF_MULTICAST;
> +       dev->flags              = IFF_RUNNING | IFF_MULTICAST;
>         dev->watchdog_timeo     = 0;
>
>         dev->netdev_ops         = &netdev_ops;
> --
> 2.8.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux