Hi,
On 06/20/2016 09:49 AM, Patrik Flykt wrote:
> Set MAC address length according to the 6LoWPAN link layer in use.
> Bluetooth Low Energy uses 48 bit addressing while IEEE802.15.4 uses
> 64 bits.
>
> Signed-off-by: Patrik Flykt <patrik.flykt@xxxxxxxxxxxxxxx>
> ---
> net/6lowpan/core.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c
> index 5945f7e..5f9909a 100644
> --- a/net/6lowpan/core.c
> +++ b/net/6lowpan/core.c
> @@ -23,7 +23,16 @@ int lowpan_register_netdevice(struct net_device *dev,
> {
> int i, ret;
>
> - dev->addr_len = EUI64_ADDR_LEN;
> + switch (lltype) {
> + case LOWPAN_LLTYPE_IEEE802154:
> + dev->addr_len = EUI64_ADDR_LEN;
> + break;
remove this case.
> +
> + case LOWPAN_LLTYPE_BTLE:
> + dev->addr_len = ETH_ALEN;
> + break;
> + }
> +
I would add here an default branch which does the EUI64 handling. EUI64
should be the normal case, all others doesn't has a EUI64 and then there
exists some mechanism to create the EUI64 from e.g. EUI48 address.
Switch case with one case branch makes not really sense, maybe use if
here.
Also cc linux-wpan for net/6lowpan/ patches.
- Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
