Hi Markus, On Wed, May 18, 2016 at 10:59 AM, Kasper Markus (ETAS-PSC/ECE1) <Markus.Kasper@xxxxxxxxxxx> wrote: > Hi, > >> -----Original Message----- >> From: linux-bluetooth-owner@xxxxxxxxxxxxxxx [mailto:linux-bluetooth- >> owner@xxxxxxxxxxxxxxx] On Behalf Of Luiz Augusto von Dentz >> Sent: Tuesday, May 17, 2016 4:22 PM >> Subject: Re: [PATCHv2 BlueZ 1/6] doc/gatt-api: Add options dictionary to >> ReadValue/WriteValue >> >> Hi, >> >> On Tue, May 10, 2016 at 1:57 AM, Vinicius Costa Gomes >> <vinicius.gomes@xxxxxxxxx> wrote: >> > Hi Luiz, >> > >> > Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> writes: >> > >> >> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx> >> >> >> >> This adds the possibility to pass an offset to these operations, and >> >> also in the server case to give the device object. >> >> --- >> >> v2: Fix Vinicius comments, add necessary changes to other tools affected. >> >> >> > >> > The series is looking good. >> >> If there are no comments to this set I will be pushing by the end of the day. > > Currently the write command inherently selects a write method based on the characteristics properties (write-without-response, reliable-write...). > The option dictionary within the API allows for adding another option to override the default selection of the write method for characteristics supporting multiple write options. > I thus consider this patch a more generic enabler within the given API to path the way for further improvements. Yes, I don't know where using a specific method would actually be recommended since it the server should be able to indicate the proper operation to use via properties but in case there is a real case where the server has the properties somewhat broken then perhaps we can include such feature. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
