Hi Vinicius,
On Sat, May 7, 2016 at 10:57 PM, Vinicius Costa Gomes
<vinicius.gomes@xxxxxxxxx> wrote:
> Hi Luiz,
>
> Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> writes:
>
>>>> +static int parse_options(DBusMessage *msg, uint16_t *offset)
>>>> +{
>>>> + DBusMessageIter args, flags;
>>>> +
>>>> + if (!dbus_message_iter_init(msg, &args))
>>>> + return -EINVAL;
>>>> +
>>>> + if (dbus_message_iter_get_arg_type(&args) != DBUS_TYPE_ARRAY)
>>>> + return -EINVAL;
>>>> +
>>>> + dbus_message_iter_recurse(&args, &flags);
>>>> + if (dbus_message_iter_get_arg_type(&flags) != DBUS_TYPE_DICT_ENTRY)
>>>> + return -EINVAL;
>>>> +
>>>
>>> I would think that from the documentation, "Possible options", that providing
>>> the offset would be optional. I don't think much is gained making this mandatory.
>>
>> I guess you are referring to empty array, so yes we should probably
>> drop the check for dict entry so it can be empty since it is optional.
>>
>
> I was thinking that a ReadValue() message without any arguments would
> make sense to be valid. And one less thing to change in applications if
> they don't need the offset.
We can't do that because D-Bus doesn't support method overloading thus
the signature must be a{sv}, but it can be an empty container so we
would default to offset 0 as it is currently.
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
