Hi Marcel, > From: linux-bluetooth-owner@xxxxxxxxxxxxxxx [mailto:linux-bluetooth- > owner@xxxxxxxxxxxxxxx] On Behalf Of Marcel Holtmann > Sent: Wednesday, January 27, 2016 8:51 PM > To: Amitkumar Karwar > Cc: linux-bluetooth@xxxxxxxxxxxxxxx; Cathy Luo; Nishant Sarmukadam; > Ganapathi Bhat > Subject: Re: [PATCH] hciattach: Add support for Marvell Bluetooth device > > Hi Amitkumar, > > > This patch enables the Marvell Bluetooth device (UART sku) over the H4 > > protocol. It configures the baudrate and download firmware to bring up > > the device. > > > > Command syntax: hciattach /dev/ttyUSB0 marvell > > > > Make sure to place the marvell_hci_uart.conf file in > > /lib/firmware/mrvl/ > > > > This file should contain below info: > > HELPER_FILE_PATH=<full path of helper binary> FIRMWARE_FILE_PATH=<full > > path of firmware binary> FIRMWARE_DOWNLOAD_BAUD_RATE=<firmware > > download baud rate> > > I would prefer if you create a drivers/bluetooth/hci_mrvl.c kernel > driver that works with btattach. We are trying to phase out hciattach > and not add more vendor specifics. > > For at least Intel and Broadcom hardware we have full in kernel support > for firmware loading and configuration. And the benefit is that code can > be shared between UART and USB. > Thanks for the quick reply. We are working on in kernel firmware download support as well by adding hci_mrvl.c file. We will submit the driver patch in couple of days. This hciattach enhancement would be really useful for the users having older kernel. Both the approaches can work independently, as here H4 UART protocol is being used instead of MRVL. Could you please considered this patch? Regards, Amitkumar -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
