AW: [BUG] LEAdvertisingManager suffers from ObjectManager hierarchy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,


> -----Ursprüngliche Nachricht-----
> Von: Luiz Augusto von Dentz [mailto:luiz.dentz@xxxxxxxxx]
> Hi Markus,
> 
> On Thu, Jan 21, 2016 at 5:53 PM, Kasper Markus (ETAS-PSC/ECE1)
> <Markus.Kasper@xxxxxxxxxxx> wrote:
> Actually LEAdvertisementManager1.RegisterAdvertisement does no actually
> require ObjectManager, so the following shall probably work:
> 
> iff --git a/src/advertising.c b/src/advertising.c index 59c8c3d..4b87d42 100644
> --- a/src/advertising.c
> +++ b/src/advertising.c
> @@ -591,7 +591,7 @@ static struct advertisement
> *advertisement_create(DBusConnection *conn,
>                 return NULL;
> 
>         ad = new0(struct advertisement, 1);
> -       ad->client = g_dbus_client_new_full(conn, sender, path, path);
> +       ad->client = g_dbus_client_new_full(conn, sender, path, NULL);
>         if (!ad->client)
>                 goto fail;
I tried this solution --> works like a charm. Previously I fixed it by adapting the api to take path and rootpath (= obj. Manager path) and then added rootpath as the fourth parameter to the call above.
But your fix is obviously much simpler. Will you commit it? You'd most likely be much faster than I am. 

> > Re contributing:
Thanks for clearing this up. The part in "HACKING" didn't mention both (user & kernel) and I missed the cleaner statement within the maintainers guidelines.
> > Especially, the "how/where to commit/send?" is not really clear to me.
What I read is: send patches formatted as text to this list (i.e. output of diff -Nurp).

Thanks again,
Markus


��.n��������+%������w��{.n�����{����^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�

[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux