From: Johan Hedberg <johan.hedberg@xxxxxxxxx> Sent: Thursday, January 21, 2016 4:43 PM > To: b38611@xxxxxxxxxxxxx > Cc: marcel@xxxxxxxxxxxx; johannes.berg@xxxxxxxxx; jslaby@xxxxxxx; linux- > bluetooth@xxxxxxxxxxxxxxx; Fugang Duan <fugang.duan@xxxxxxx> > Subject: Re: [PATCH] Bluetooth: add hdev check to avoid passing null pointer > > Hi Fuang, > > On Thu, Jan 21, 2016, Fugang Duan wrote: > > Function hci_mgmt_cmd() may pass hdev with null pointer to > > hci_mgmt_handler->func() like below code: > > err = handler->func(sk, hdev, cp, len); > > > > Add hdev check to avoid passing null pointer. > > > > Signed-off-by: Fugang Duan <B38611@xxxxxxxxxxxxx> > > --- > > net/bluetooth/hci_sock.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c index > > 1298d72..7fdfc80 100644 > > --- a/net/bluetooth/hci_sock.c > > +++ b/net/bluetooth/hci_sock.c > > @@ -1186,6 +1186,8 @@ static int hci_mgmt_cmd(struct hci_mgmt_chan > > *chan, struct sock *sk, > > > > if (hdev && chan->hdev_init) > > chan->hdev_init(sk, hdev); > > + else if (!hdev) > > + goto done; > > Why are you resending this? Did you see my response to your earlier > submission? > > Johan Sorry, maybe I missed some mail and guessed I didn't send the previous mail successfully. Let's check my mailbox Regards, Andy -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
