Re: [PATCH 4/5] Bluetooth: hci_intel: Enter manufacturing mode if requested

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Loic,

> LhP controller only sends manufacturing error if not correctly
> configured (after first boot), nothing else.
> In order to avoid a read intel version command timeout due to missing
> command complete event, inject the event with an error status.

can we actually get the events that the controller sends. I think we either get a manufacturing error or a bootup event. Both can be taken as indicator that this is LhP and not LnP.

If this turns into something too complicated, we might just create a hci_ag6xx.c and treat this as a separate driver for yet another part of Intel hardware. Or another alternative is to add a HCIUARTSETOPTS or HCIUARTSETVNDFLAGS or similar to allow for driver specific flags.

Entering manufacturer mode is suppose to be no op for LnP for backwards compatible reasons. Leaving the manufacturer mode will fail on LnP. So we could just send that command no matter what. However I remember that LnP really wants a Intel Read Version command first. At least with some bootloader versions.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux