Hi Marcel, > From: Marcel Holtmann [mailto:marcel@xxxxxxxxxxxx] > Sent: Thursday, November 26, 2015 6:37 PM > To: Amitkumar Karwar > Cc: linux-bluetooth@xxxxxxxxxxxxxxx; Cathy Luo; Xinming Hu > Subject: Re: [PATCH] Bluetooth: btmrvl: add sysfs commands gpiogap and > hscfgcmd > > Hi Amitkumar, > > > This patch adds support for driver's internal host sleep configuration > > via sysfs. gpiogap and hscfgcmd sysfs commands are added for this > > purpose. > > > > Examples. > > 1. Get current gpiogap > > cat /sys/class/bluetooth/hci0/gpiogap 2. Set gpio as 13 and gap as > > 100msecs > > echo "0x0d64" > /sys/class/bluetooth/hci0/gpiogap 3. Download host > > sleep configuration to firmware. > > echo "1" > /sys/class/bluetooth/hci0/hscfgcmd > > explain to me how this is a good API. Keep in mind this is an userspace > API and needs to be stable. > > If you want to expose a GPIO, why not expose it through the standard > Linux kernel GPIO API. Then it becomes easily discoverable via standard > sysfs tools. Also you can use standard tools to modify it. > > I also do not understand why you need something to set host sleep > configuration. Just do this all the time and be done with it. Thanks for the review. I wasn't aware about standard linux kernel GPIO API. I will go through below link and check how we can make use of it. http://lxr.free-electrons.com/source/Documentation/gpio/sysfs.txt Basically we have gpiogap and hscfgcmd debugfs commands. As production kernel doesn't enable CONFIG_DEBUGFS, we tried to do same thing via sysfs. Regards, Amitkumar -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
