Re: Bug in batostr()?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Antoine,

> In lib/bluetooth.c, it looks like batostr() is bugged (wrong bytes order), 
> after comparison with ba2str():
> 
> char *batostr(const bdaddr_t *ba)
> 	sprintf(str, "%2.2X:%2.2X:%2.2X:%2.2X:%2.2X:%2.2X",
> 		ba->b[0], ba->b[1], ba->b[2],
> 		ba->b[3], ba->b[4], ba->b[5]);
> 
> int ba2str(const bdaddr_t *ba, char *str)
> 	return sprintf(str, "%2.2X:%2.2X:%2.2X:%2.2X:%2.2X:%2.2X",
> 		ba->b[5], ba->b[4], ba->b[3], ba->b[2], ba->b[1], ba->b[0]);
> 
> This function is not called anywhere else in the repository, that is probably 
> why the problem never showed up.

they are on purpose this way. That is why we also have baswap.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux