Re: bluetoothd crashes when media endpoint SelectConfiguration reply does not contain an array

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23 November 2015 at 12:47, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
> Hi Michael,
>
> On Sun, Nov 22, 2015 at 12:45 AM, Michal Suchanek <hramrach@xxxxxxxxx> wrote:
>> Hello,
>>
>> I am using bluez 5.36 on Debian.
>>
>> I tried to export a media source from an application. However, when
>> the SelectConfiguration call finishes bluetoothd crashes.
>>
>> Looking at the code there is no check that the return from the
>> callback actually contains an array before trying to extract the array
>> content.
>>
>> Adding a check avoids the crash in bluetoothd.
>>
>> I am not sure why the return value does not contain a proper
>> capabilities array but that is another issue.
>>
>> Sending a patch that fixes the problem for me.
>
> The fix looks good, please send a proper patch so I can apply. About
> the response not being an array, this is probably a custom endpoint
> because with PA or simple-endpoint but should respond properly, but it
> is a valid fix anyway.
>

Yes, it is a custom endpoind. I found that these dbus bindings require
you to specify a return value type othewise returned data is silently
trashed and nothing is passed to the caller.

I tried using PA but everything locks up when the BT sink device goes
out of proximity so I will pass on this for now.

I will try to generate a patch with git.

Thanks

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux