Re: [PATCH] BNEP multicast filter is filtering multicast addresses in default case although differently specified

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Danny,

> This patch fixes the Bug 106691 by changing the default multicast filter
> to not filter out any multicast addresses.
> 
> ---
> net/bluetooth/bnep/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bluetooth/bnep/core.c b/net/bluetooth/bnep/core.c
> index 1641367..ba2467a 100644
> --- a/net/bluetooth/bnep/core.c
> +++ b/net/bluetooth/bnep/core.c
> @@ -609,7 +609,7 @@ int bnep_add_connection(struct bnep_connadd_req
> *req, struct socket *sock)
> 
> #ifdef CONFIG_BT_BNEP_MC_FILTER
> 	/* Set default mc filter */
> -	set_bit(bnep_mc_hash(dev->broadcast), (ulong *) &s->mc_filter);
> +	s->mc_filter = ~0LL;
> #endif

I am not convinced that these two are actually the same expressions. You need to explain this a lot more in detail on why this change is correct.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux