Re: [PATCH bluetooth-next] bluetooth: 6lowpan: fix NOHZ: local_softirq_pending

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I have verified that this works.

Acked-by: Jukka Rissanen <jukka.rissanen@xxxxxxxxxxxxxxx>


Cheers,
Jukka


On ti, 2015-10-27 at 08:35 +0100, Alexander Aring wrote:
> Jukka reported about the following warning:
> 
> "NOHZ: local_softirq_pending 08"
> 
> I remember this warning and we had a similar issue when using workqueues
> and calling netif_rx. See commit 5ff3fec ("mac802154: fix NOHZ
> local_softirq_pending 08 warning").
> 
> This warning occurs when calling "netif_rx" inside the wrong context
> (non softirq context). The net core api offers "netif_rx_ni" to call
> netif_rx inside the correct softirq context.
> 
> Reported-by: Jukka Rissanen <jukka.rissanen@xxxxxxxxxxxxxxx>
> Cc: Jukka Rissanen <jukka.rissanen@xxxxxxxxxxxxxxx>
> Signed-off-by: Alexander Aring <alex.aring@xxxxxxxxx>
> ---
>  net/bluetooth/6lowpan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
> index d85af23..9e9cca3 100644
> --- a/net/bluetooth/6lowpan.c
> +++ b/net/bluetooth/6lowpan.c
> @@ -263,7 +263,7 @@ static int give_skb_to_upper(struct sk_buff *skb, struct net_device *dev)
>  	if (!skb_cp)
>  		return NET_RX_DROP;
>  
> -	return netif_rx(skb_cp);
> +	return netif_rx_ni(skb_cp);
>  }
>  
>  static int iphc_decompress(struct sk_buff *skb, struct net_device *netdev,


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux