Re: [RFC] Bluetooth: Remove __l2cap_wait_ack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,

> __l2cap_wait_ack probably cause more harm than good since it was added as
> a feature to wait until all unacked packets are processed and properly
> acked by the remote but it ignored the fact that the remote may probably
> wait some window threshold before start acking.
> 
> Since the window threshold is implementation specific, we ack when the
> window is 3/4th full, it should probably be the receiving side that
> should ack or discard the packets in the queue when processing the
> Disconnect request.
> 
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
> ---
> net/bluetooth/l2cap_sock.c | 50 ----------------------------------------------
> 1 file changed, 50 deletions(-)

I would feel a lot better if we had a l2cap-tester test case or two to confirm the expected behavior.

Additionally has anyone tested this patch and confirmed that it does not do harm or break qualification?

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux