Hi Jakub,
On Thu, Oct 15, 2015, Jakub Pawlowski wrote:
> When disble/enable scan command is issued twice, some controllers would
> return error for second request. Therefore requests including those would
> fail on some controllers, and succeed on others.
Do you actually have examples of controllers that don't fail? I haven't
seen any. Also, the usual convention is the provide a btmon output
snippet of the failure in the commit message.
> @@ -6124,7 +6124,11 @@ static int hci_conn_params_set(struct hci_request *req, bdaddr_t *addr,
> case HCI_AUTO_CONN_ALWAYS:
> if (!is_connected(hdev, addr, addr_type)) {
> list_add(¶ms->action, &hdev->pend_le_conns);
> - __hci_update_background_scan(req);
> + /* If we are connecting to device using random address,
> + * we were already added to pend_le_conns and scanning.
> + */
> + if (params->auto_connect != HCI_AUTO_CONN_EXPLICIT)
> + __hci_update_background_scan(req);
The patch looks in general fine, but the above code comment has always
confused me. What has this got to do with random addresses? Wouldn't we
be scanning regardless of what type of address had previously been
added?
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
