On Wed 14 Oct 08:10 PDT 2015, yfw wrote:
[..]
> > diff --git a/drivers/bluetooth/Makefile b/drivers/bluetooth/Makefile
[..]
> > +static int btqcomsmd_probe(struct qcom_smd_device *sdev)
> > +{
> > + struct qcom_smd_channel *acl;
> > + struct btqcomsmd *btq;
> > + struct hci_dev *hdev;
> > + int ret;
> > +
> > + acl = qcom_smd_open_channel(sdev,
> > + "APPS_RIVA_BT_ACL",
> > + btqcomsmd_acl_callback);
> > + if (IS_ERR(acl))
> > + return PTR_ERR(acl);
> Do we need to close acl channel in following failure path and
> btqcomsmd_remove?
>
As the life cycle of the channels implicitly follow the life cycle of
the qcom_smd_device the channel is supposed to be released by the
caller of probe upon failure.
I'll make sure this is documented in qcom_smd_open_channel()
Thanks for the review.
Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
