Re: [PATCH] core/advertising: Fix string match in le adv search

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrejs,

On Tue, Oct 6, 2015 at 2:46 PM, Andrejs Hanins <andrejs.hanins@xxxxxxxx> wrote:
> Instead of searching for matched entry in the list, the function match_advertisement
> was searching for the first non-matched entry. As a result, it wasn't possible to
> unregister existing advertisement from LE Adv manager.
>
> Signed-off-by: Andrejs Hanins <andrejs.hanins@xxxxxxxx>

Please remember no signed-off-by in userspace and keep the description
under 72 columns, this time I fixed it for you.

> ---
>  src/advertising.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/advertising.c b/src/advertising.c
> index d56b7a2..a148625 100644
> --- a/src/advertising.c
> +++ b/src/advertising.c
> @@ -77,10 +77,10 @@ static bool match_advertisement(const void *a, const void *b)
>         const struct advertisement *ad = a;
>         const struct dbus_obj_match *match = b;
>
> -       if (match->owner && !g_strcmp0(ad->owner, match->owner))
> +       if (match->owner && g_strcmp0(ad->owner, match->owner))
>                 return false;
>
> -       if (match->path && !g_strcmp0(ad->path, match->path))
> +       if (match->path && g_strcmp0(ad->path, match->path))
>                 return false;
>
>         return true;
> --
> 1.9.1

Nice catch, applied.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux