Hello Marcel Holtmann,
The patch 8af9da1ab784: "Bluetooth: btbcm: Read the local name in
setup stage" from Oct 5, 2015, leads to the following static checker
warning:
drivers/bluetooth/btbcm.c:533 btbcm_setup_apple()
error: 'skb' dereferencing possible ERR_PTR()
drivers/bluetooth/btbcm.c
522 /* Read Verbose Config Version Info */
523 skb = btbcm_read_verbose_config(hdev);
524 if (!IS_ERR(skb)) {
525 BT_INFO("%s: BCM: chip id %u build %4.4u", hdev->name,
526 skb->data[1], get_unaligned_le16(skb->data + 5));
527 kfree_skb(skb);
528 }
529
530 /* Read Local Name */
531 skb = btbcm_read_local_name(hdev);
532 if (IS_ERR(skb)) {
This test is reversed?
533 BT_INFO("%s: %s", hdev->name, (char *)(skb->data + 1));
534 kfree_skb(skb);
535 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
