Re: [PATCH 2/2] tools: Fix Invalid return

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bharat,

On Thu, Oct 1, 2015 at 2:49 PM, Bharat Panda <bharat.panda@xxxxxxxxxxx> wrote:
> Return DBUS_HANDLER_RESULT_HANDLED instead of
> DBUS_HANDLER_RESULT_NOT_YET_HANDLED for player message handle.
> ---
>  tools/mpris-proxy.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/mpris-proxy.c b/tools/mpris-proxy.c
> index 693055e..2a5cbae 100644
> --- a/tools/mpris-proxy.c
> +++ b/tools/mpris-proxy.c
> @@ -205,6 +205,7 @@ static void append_container(DBusMessageIter *base, DBusMessageIter *iter,
>         case DBUS_TYPE_ARRAY:
>         case DBUS_TYPE_VARIANT:
>                 sig = dbus_message_iter_get_signature(&iter_sub);
> +               printf("signature: %s\n", sig);
>                 break;
>         default:
>                 sig = NULL;
> @@ -406,7 +407,7 @@ static DBusHandlerResult player_message(DBusConnection *conn,
>  done:
>         dbus_message_unref(copy);
>
> -       return DBUS_HANDLER_RESULT_NOT_YET_HANDLED;
> +       return DBUS_HANDLER_RESULT_HANDLED;
>  }
>
>  static struct player *find_player_by_bus_name(const char *name)
> --
> 1.9.1

I went ahead and applied this one, note that I removed the printf.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux