Re: [PATCH v3 1/2] gdbus: add method for immediate property update

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jakub,

On Fri, Sep 18, 2015, Jakub Pawlowski wrote:
> +void g_dbus_emit_property_changed_full(DBusConnection *connection,
> +				const char *path, const char *interface,
> +				const char *name, gboolean flush);

I can't say I'm a fan of boolean parameters like this where it's
essentially impossible to say when looking at the calling code what the
parameter does (in this case the completely generic "full" in the
function name doesn't even give any hints about what exactly the
parameter might be). Instead, using a flags parameter + enum would be
one way to keep the calling code understandable.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux