Re: [PATCH BlueZ v2 1/5] audio/avrcp: Fix missing event for volume control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Sep 15, 2015 at 3:41 PM, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>
> CT and TG are always relative to client and server role, so although TG is
> associated with a player and CT with a remote controller in case of volume
> control the CT is in fact the player and the TG the remote controller,
> because of that PTS will not register any TG record when testing this thus
> controller_init will not register the necessary events.
> ---
>  profiles/audio/avrcp.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
> index 750bdd9..703d084 100644
> --- a/profiles/audio/avrcp.c
> +++ b/profiles/audio/avrcp.c
> @@ -3805,7 +3805,8 @@ static void target_init(struct avrcp *session)
>
>         session->supported_events |=
>                                 (1 << AVRCP_EVENT_ADDRESSED_PLAYER_CHANGED) |
> -                               (1 << AVRCP_EVENT_AVAILABLE_PLAYERS_CHANGED);
> +                               (1 << AVRCP_EVENT_AVAILABLE_PLAYERS_CHANGED) |
> +                               (1 << AVRCP_EVENT_VOLUME_CHANGED);
>
>         /* Only check capabilities if controller is not supported */
>         if (session->controller == NULL)
> @@ -3831,9 +3832,6 @@ static void controller_init(struct avrcp *session)
>
>         DBG("%p version 0x%04x", controller, controller->version);
>
> -       if (controller->version >= 0x0104)
> -               session->supported_events |= (1 << AVRCP_EVENT_VOLUME_CHANGED);
> -
>         service = btd_device_get_service(session->dev, AVRCP_TARGET_UUID);
>         btd_service_connecting_complete(service, 0);
>
> --
> 2.4.3

Pushed.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux