Re: [PATCH v4 1/5] Bluetooth: Add BT_WARN and bt_dev_warn logging macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Fred,

> Add warning logging macros to bluetooth subsystem logs.
> 
> Signed-off-by: Frederic Danis <frederic.danis@xxxxxxxxxxxxxxx>
> ---
> include/net/bluetooth/bluetooth.h | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
> index fcf2ae7..27a3f16 100644
> --- a/include/net/bluetooth/bluetooth.h
> +++ b/include/net/bluetooth/bluetooth.h
> @@ -125,11 +125,14 @@ __printf(1, 2)
> void bt_err(const char *fmt, ...);
> 
> #define BT_INFO(fmt, ...)	bt_info(fmt "\n", ##__VA_ARGS__)
> +#define BT_WARN(fmt, ...)	pr_warn(fmt "\n", ##__VA_ARGS__)

any reason why you didn't create a bt_warn instead here? That why we have the proper pr_fmt set with the Bluetooth: prefix.

> #define BT_ERR(fmt, ...)	bt_err(fmt "\n", ##__VA_ARGS__)
> #define BT_DBG(fmt, ...)	pr_debug(fmt "\n", ##__VA_ARGS__)
> 
> #define bt_dev_info(hdev, fmt, ...)				\
> 	BT_INFO("%s: " fmt, (hdev)->name, ##__VA_ARGS__)
> +#define bt_dev_warn(hdev, fmt, ...)				\
> +	BT_WARN("%s: " fmt, (hdev)->name, ##__VA_ARGS__)
> #define bt_dev_err(hdev, fmt, ...)				\
> 	BT_ERR("%s: " fmt, (hdev)->name, ##__VA_ARGS__)
> #define bt_dev_dbg(hdev, fmt, ...)				\

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux