Re: [PATCH] Bluetooth: close HCI device when user channel socket gets closed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Simon,

> With 9380f9eacfbbee701daa416edd6625efcd3e29e1 the order of unsetting
> the HCI_USER_CHANNEL flag of the HCI device was reverted to ensure
> the device is first closed before making it available again.
> 
> Due to hci_dev_close checking for HCI_USER_CHANNEL being set on the
> device it was never really closed and was kept opened. We're now
> calling hci_dev_do_close directly to make sure the device is correctly
> closed and we keep the correct order to unset the flag on our device
> object.
> 
> Signed-off-by: Simon Fels <simon.fels@xxxxxxxxxxxxx>
> ---
> include/net/bluetooth/hci_core.h | 1 +
> net/bluetooth/hci_core.c         | 2 +-
> net/bluetooth/hci_sock.c         | 2 +-
> 3 files changed, 3 insertions(+), 2 deletions(-)

patch has been applied to bluetooth-next tree.

However I added an extra comment into the code on why this is actually doing the right thing in the end. I mentioned before that I failed to comment on this before and we do not want to keep forgetting to comment on code that is not intuitive.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux