Re: [PATCH 2/2] audio/avrcp: Set Media Player Properties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bharat,

On Thu, Aug 20, 2015 at 12:03 PM, Bharat Panda <bharat.panda@xxxxxxxxxxx> wrote:
> Add methods to set missing media player properties value, like
> player name, type, sub-type and features.
> ---
>  profiles/audio/media.c | 81 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 81 insertions(+)
>
> diff --git a/profiles/audio/media.c b/profiles/audio/media.c
> index ed441d0..f55ecc1 100644
> --- a/profiles/audio/media.c
> +++ b/profiles/audio/media.c
> @@ -112,6 +112,10 @@ struct media_player {
>         bool                    next;
>         bool                    previous;
>         bool                    control;
> +       char                    *name;
> +       char                    *type;
> +       char                    *subtype;
> +       unsigned int            features[16];
>  };

To start with I would like to just have the passed to, for the rest we
can assume some values and disable all the features that require the
browsing command.

>  static GSList *adapters = NULL;
> @@ -1607,6 +1611,71 @@ static gboolean set_flag(struct media_player *mp, DBusMessageIter *iter,
>         return TRUE;
>  }
>
> +static gboolean set_name(struct media_player *mp, DBusMessageIter *iter)
> +{
> +       const char *value;
> +
> +       if (dbus_message_iter_get_arg_type(iter) != DBUS_TYPE_STRING)
> +               return FALSE;
> +
> +       dbus_message_iter_get_basic(iter, &value);
> +
> +       if (g_strcmp0(mp->name, value) == 0)
> +               return TRUE;
> +
> +       mp->name = g_strdup(value);
> +
> +       return TRUE;
> +}
> +
> +static gboolean set_type(struct media_player *mp, DBusMessageIter *iter)
> +{
> +       const char *value;
> +
> +       if (dbus_message_iter_get_arg_type(iter) != DBUS_TYPE_STRING)
> +               return FALSE;
> +
> +       dbus_message_iter_get_basic(iter, &value);
> +
> +       mp->type = g_strdup(value);
> +
> +       return TRUE;
> +}
> +
> +static gboolean set_features(struct media_player *mp, DBusMessageIter *iter)
> +{
> +       const char *value;
> +       uint8_t i = 0;
> +
> +       if (dbus_message_iter_get_arg_type(iter) != DBUS_TYPE_STRING)
> +               return FALSE;
> +
> +       dbus_message_iter_get_basic(iter, &value);
> +
> +       memset(&mp->features, 0x00, 16);
> +
> +       while ((i < (strlen(value)/2))) {
> +               sscanf(value+(2*i), "%02x", &mp->features[i]);
> +               i++;
> +       }
> +
> +       return TRUE;
> +}
> +
> +static gboolean set_subtype(struct media_player *mp, DBusMessageIter *iter)
> +{
> +       const char *value;
> +
> +       if (dbus_message_iter_get_arg_type(iter) != DBUS_TYPE_STRING)
> +               return FALSE;
> +
> +       dbus_message_iter_get_basic(iter, &value);
> +
> +       mp->subtype = g_strdup(value);
> +
> +       return TRUE;
> +}
> +
>  static gboolean set_player_property(struct media_player *mp, const char *key,
>                                                         DBusMessageIter *entry)
>  {
> @@ -1647,6 +1716,18 @@ static gboolean set_player_property(struct media_player *mp, const char *key,
>         if (strcasecmp(key, "CanControl") == 0)
>                 return set_flag(mp, &var, &mp->control);
>
> +       if (strcasecmp(key, "DisplayName") == 0)
> +               return set_name(mp, &var);
> +
> +       if (strcasecmp(key, "Type") == 0)
> +               return set_type(mp, &var);
> +
> +       if (strcasecmp(key, "SubType") == 0)
> +               return set_subtype(mp, &var);
> +
> +       if (strcasecmp(key, "Features") == 0)
> +               return set_features(mp, &var);
> +
>         DBG("%s not supported, ignoring", key);
>
>         return TRUE;
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux