On Thu, Jul 30, 2015 at 1:54 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> Hi Jakub,
>
>> Make sure that MGMT_STATUS_INVALID_PARAMS is returned when non identity
>> address is passed to ADD_DEVICE. Right now MGMT_STATUS_FAILED is
>> returned, which might be misleading.
>>
>> Signed-off-by: Jakub Pawlowski <jpawlowski@xxxxxxxxxx>
>> ---
>> net/bluetooth/mgmt.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
>> index 7998fb2..47462bf 100644
>> --- a/net/bluetooth/mgmt.c
>> +++ b/net/bluetooth/mgmt.c
>> @@ -6226,6 +6226,13 @@ static int add_device(struct sock *sk, struct hci_dev *hdev,
>> else
>> auto_conn = HCI_AUTO_CONN_REPORT;
>>
>> + /* Allow only identity addresses */
>> + if (!hci_is_identity_address(&cp->addr.bdaddr, addr_type)) {
>> + err = cmd->cmd_complete(cmd, MGMT_STATUS_INVALID_PARAMS);
>> + mgmt_pending_remove(cmd);
>> + goto unlock;
>> + }
>> +
>
> did we loose this patch or is it no longer needed?
>
It's no longer needed, it was squashed with other patch.
Thanks,
Jakub
> Regards
>
> Marcel
>
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
