Hi Atul, On Monday 29 of June 2015 12:14:13 Atul Rai wrote: > Add NULL check on malloc return to fix NULL pointer dereference > in case malloc fails. > --- > android/hal-bluetooth.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/android/hal-bluetooth.c b/android/hal-bluetooth.c > index e24f7d2..66f4a37 100644 > --- a/android/hal-bluetooth.c > +++ b/android/hal-bluetooth.c > @@ -19,6 +19,7 @@ > #include <stdlib.h> > #include <stdbool.h> > #include <string.h> > +#include <errno.h> > > #include <cutils/properties.h> > > @@ -1103,6 +1104,11 @@ static int open_bluetooth(const struct hw_module_t > *module, char const *name, > > DBG(""); > > + if (!dev) { > + error("Failed to allocate memory for device"); > + return -ENOMEM; > + } > + > memset(dev, 0, sizeof(bluetooth_device_t)); > dev->common.tag = HARDWARE_DEVICE_TAG; > dev->common.version = 0; Patch applied, thanks. -- BR Szymon Janc -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html