Re: [PATCH v2] audio/avrcp: Handle Available Players Changed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bharat,

On Wed, Jul 22, 2015 at 1:19 PM, Bharat Panda <bharat.panda@xxxxxxxxxxx> wrote:
> Add support to handle AVRCP_EVENT_AVAILABLE_PLAYERS_CHANGED
> notification.
> - Register notification for "Available Players Changed"
> - Send interim and final responses on change in available palyers.

Could you please add the HCI traces of these events, also there a typo
in the line above, it should players.

> ---
>  profiles/audio/avrcp.c | 7 +++++++
>  profiles/audio/media.c | 6 ++++++
>  2 files changed, 13 insertions(+)
>
> diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
> index 60f8cbf..b22f2fe 100644
> --- a/profiles/audio/avrcp.c
> +++ b/profiles/audio/avrcp.c
> @@ -673,6 +673,9 @@ void avrcp_player_event(struct avrcp_player *player, uint8_t id,
>                 pdu->params[size++] = attr;
>                 pdu->params[size++] = val;
>                 break;
> +       case AVRCP_EVENT_AVAILABLE_PLAYERS_CHANGED:
> +               size = 1;
> +               break;
>         default:
>                 error("Unknown event %u", id);
>                 return;
> @@ -1490,6 +1493,9 @@ static uint8_t avrcp_handle_register_notification(struct avrcp *session,
>                 }
>
>                 break;
> +       case AVRCP_EVENT_AVAILABLE_PLAYERS_CHANGED:
> +               len = 1;
> +               break;
>         case AVRCP_EVENT_VOLUME_CHANGED:
>                 pdu->params[1] = media_transport_get_device_volume(dev);
>                 if (pdu->params[1] > 127)
> @@ -3435,6 +3441,7 @@ static void target_init(struct avrcp *session)
>                                 (1 << AVRCP_EVENT_TRACK_CHANGED) |
>                                 (1 << AVRCP_EVENT_TRACK_REACHED_START) |
>                                 (1 << AVRCP_EVENT_TRACK_REACHED_END) |
> +                               (1 << AVRCP_EVENT_AVAILABLE_PLAYERS_CHANGED) |
>                                 (1 << AVRCP_EVENT_SETTINGS_CHANGED);
>
>         if (target->version < 0x0104)
> diff --git a/profiles/audio/media.c b/profiles/audio/media.c
> index ed441d0..83a9a10 100644
> --- a/profiles/audio/media.c
> +++ b/profiles/audio/media.c
> @@ -988,6 +988,9 @@ static void media_player_remove(struct media_player *mp)
>  {
>         info("Player unregistered: sender=%s path=%s", mp->sender, mp->path);
>
> +       avrcp_player_event(mp->player,
> +                               AVRCP_EVENT_AVAILABLE_PLAYERS_CHANGED, NULL);
> +
>         media_player_destroy(mp);
>  }
>
> @@ -1799,6 +1802,9 @@ static DBusMessage *register_player(DBusConnection *conn, DBusMessage *msg,
>                 return btd_error_invalid_args(msg);
>         }
>
> +       avrcp_player_event(mp->player,
> +                               AVRCP_EVENT_AVAILABLE_PLAYERS_CHANGED, NULL);
> +
>         return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
>  }
>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux